Page MenuHome GnuPG
Create Task
Maniphest T7423

Fix performance of UserIDProxyModel
Closed, ResolvedPublic
Actions

Description

When using a large key ring (~2000 Keys with ~4000 user ids), the UserIDProxyModel performs poorly, leading to very long loading times for the sign/encrypt dialog (~30 seconds on my machine).

Details

External Link
https://invent.kde.org/pim/libkleo/-/merge_requests/169

Revisions and Commits

rLIBKLEO Libkleo
rLIBKLEO64bac3eceef0 UserIDProxyModel: Keep an index for proxy index -> source index mapping
rLIBKLEOcf7b36268b92 UserIDProxyModel: Keep an index for proxy index -> source index mapping
rLIBKLEO93c3559b42a8 UserIDProxyModel: Keep an index for proxy index -> source index mapping
rLIBKLEO4abc1ce456a6 UserIDProxyModel: Keep an index for proxy index -> source index mapping
rLIBKLEO11b32423e1bc UserIDProxyModel: Keep an index for proxy index -> source index mapping
rLIBKLEO94a21d777d69 UserIDProxyModel: Keep an index for proxy index -> source index mapping
rLIBKLEOd1b71562950e UserIDProxyModel: Keep an index for fingerprint -> source index mapping

Event Timeline

• TobiasFella created this task.Nov 21 2024, 12:12 PM
• TobiasFella renamed this task from Fx to Fix performance of UserIDProxyModel.Nov 21 2024, 12:14 PM
• TobiasFella claimed this task.
• TobiasFella triaged this task as High priority.
• TobiasFella updated the task description. (Show Details)
• TobiasFella added projects: kleopatra, vsd33.
• TobiasFella set External Link to https://invent.kde.org/pim/libkleo/-/merge_requests/169.
• TobiasFella added a commit: rLIBKLEOd1b71562950e: UserIDProxyModel: Keep an index for fingerprint -> source index mapping.Nov 21 2024, 12:18 PM
• ebo added a project: Restricted Project.Nov 21 2024, 1:39 PM
• ebo added a subscriber: • ebo.Nov 21 2024, 1:45 PM
• TobiasFella added a commit: rLIBKLEO94a21d777d69: UserIDProxyModel: Keep an index for proxy index -> source index mapping.Nov 21 2024, 3:08 PM
• TobiasFella added a commit: rLIBKLEO11b32423e1bc: UserIDProxyModel: Keep an index for proxy index -> source index mapping.Nov 22 2024, 10:29 AM
• TobiasFella added a commit: rLIBKLEO4abc1ce456a6: UserIDProxyModel: Keep an index for proxy index -> source index mapping.
• TobiasFella added a commit: rLIBKLEO93c3559b42a8: UserIDProxyModel: Keep an index for proxy index -> source index mapping.
• TobiasFella added a commit: rLIBKLEOcf7b36268b92: UserIDProxyModel: Keep an index for proxy index -> source index mapping.Nov 22 2024, 10:31 AM
• TobiasFella changed the task status from Open to Testing.Nov 22 2024, 3:16 PM
• TobiasFella moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ikloecker added a commit: rLIBKLEO64bac3eceef0: UserIDProxyModel: Keep an index for proxy index -> source index mapping.Nov 25 2024, 9:36 AM
• ebo moved this task from Backlog to WiP on the vsd33 board.Nov 25 2024, 10:59 AM
• TobiasFella added a comment.Nov 26 2024, 11:51 AM

With the fix, the dialog opens instantly (< 1 second loading time)

• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Nov 26 2024, 2:26 PM

with Gpg4win-Beta-94: about that speed on Windows, too.

• ebo moved this task from WiP to QA on the vsd33 board.Dec 16 2024, 11:19 AM
CarlSchwan closed this task as Resolved.Jan 14 2025, 2:49 PM
CarlSchwan moved this task from QA to vsd-3.3.0 on the vsd33 board.
CarlSchwan edited projects, added vsd33 (vsd-3.3.0); removed vsd33.
CarlSchwan added a subscriber: CarlSchwan.

Tested with VSD-beta-478 and performance is fine