Page MenuHome GnuPG
Create Task
Maniphest T7495

Kleopatra: Improve success message on keyserver upload
Testing, NormalPublic
Actions

Description

Follow up to T6769: Kleopatra: Change warning on keyserver upload

When you upload a certificate to a keyserver you get the success message "OpenPGP certificates exported successfully."
This is confusing. Additionally, the titel of the window shows the first part of nearly the same text and is cut short as that is too long:

For the window title that should be either the default window title or something short like "Success".

For the message "Upload successful." or even better "OpenPGP certificates uploaded successfully to %1" which could be either keyserver vs internal directory or the URL.
Edit 2025-05-13: We decided to keep it as simple as possible.

Details

External Link
https://invent.kde.org/pim/kleopatra/-/merge_requests/363

Revisions and Commits

rKLEOPATRA Kleopatra
rKLEOPATRA0484fe5985be Improve success message for key upload
rKLEOPATRA6a26951194e6 Improve success message for key upload
rKLEOPATRA16e1b9dda0d3 Improve success message for key upload
rKLEOPATRAaaa7de259757 Improve success message for key upload

Related Objects

Event Timeline

• ebo renamed this task from Draft: Kleopatra: Improve succes message on keyserver upload to Draft: Kleopatra: Improve success message on keyserver upload.Jan 29 2025, 10:35 AM
• ebo created this task.
• TobiasFella added a commit: rKLEOPATRAaaa7de259757: Improve success message for key upload.Jan 29 2025, 5:22 PM
• TobiasFella claimed this task.Jan 29 2025, 5:22 PM
• TobiasFella triaged this task as Normal priority.
• TobiasFella set External Link to https://invent.kde.org/pim/kleopatra/-/merge_requests/363.
• ebo renamed this task from Draft: Kleopatra: Improve success message on keyserver upload to Kleopatra: Improve success message on keyserver upload.May 13 2025, 3:54 PM
• ebo updated the task description. (Show Details)
• ebo added a comment.May 13 2025, 5:14 PM

I forgot the differentiation between singular and plural…
Maybe "Upload successful" would be enough.

hej added a subscriber: hej.May 13 2025, 5:21 PM

"Upload successful." or "Upload complete." (even shorter) for the title bar are fine :)

• TobiasFella added a commit: rKLEOPATRA16e1b9dda0d3: Improve success message for key upload.May 14 2025, 12:30 PM
• TobiasFella moved this task from Backlog to WIP on the gpd5x board.May 14 2025, 12:30 PM
• TobiasFella added a commit: rKLEOPATRA6a26951194e6: Improve success message for key upload.May 14 2025, 12:31 PM
• ebo updated the task description. (Show Details)May 14 2025, 12:40 PM
• TobiasFella added a commit: rKLEOPATRA0484fe5985be: Improve success message for key upload.May 15 2025, 11:22 AM
• TobiasFella changed the task status from Open to Testing.May 15 2025, 1:33 PM
• ebo added a comment.May 15 2025, 2:42 PM

Hej thinks that she would expect the dialog to show which certificates were uploaded.
I think if we want to do that, we should make a new ticket for it. Here we wanted the easy quick fix.

• ebo moved this task from WIP to QA on the gpd5x board.Jul 9 2025, 12:43 PM
timegrid moved this task from QA to Done on the gpd5x board.Fri, Nov 28, 8:35 AM
timegrid added a subscriber: timegrid.

Looks good to me on gpg4win-5.0.0-beta413 @ win11:

It takes a while for the message to display though without an indicator, that kleopatra is busy. But that would also be another ticket, if we want to change that.

timegrid added a comment.Fri, Nov 28, 8:44 AM

When an uncertified cert is uploaded, the main button of the warning message also says Export Certificate. Should this be another ticket?

• ikloecker added a subscriber: • ikloecker.Mon, Dec 1, 11:38 AM
In T7495#209088, @timegrid wrote:

When an uncertified cert is uploaded, the main button of the warning message also says Export Certificate. Should this be another ticket?

I'd say yes. The main reason for this is that I don't like changes to the scope of tickets after the original request was completed. The complete text of this window probably needs to be reworded for what we call "Publish on server" in the menu. (Now that I see it I'm wondering if "Upload" in the success message is the best word when the action is named "Publish".)

timegrid added a comment.Mon, Dec 1, 2:08 PM

I meant more like if it's worth a ticket at all, as it's an edge case and not necessarily a problem. Ebo and me already agreed, that we can live with it - but if you think it's worth it, I'll create another ticket.

Regarding "Upload" I agree, that something with "Publish" would make more sense, e.g.

  • Certificate successfully published.
  • Zertifikat erfolgreich veröffentlicht

But I wasn't involved in the discussions before, so I'm not sure if there was a reason for "upload".

• ebo added a comment.Thu, Dec 4, 2:53 PM

I believe the reason was simply that we wanted it short, "Upload successful." sounds better than"Publication successful." and I associate keyserver more with upload than publication. Furthermore "Certificate successfully published" has the disadvantage of being correct only for the upload of one certificates, not multiple. So you'd have to have case differentiation.

But you're right, we could make the wording more consistent. There are other error messages in the context which use deviating wording, too, e.g "Exporting the certificate to a key server is not possible … "