Page MenuHome GnuPG
Create Task
Maniphest T7780

Kleopatra: upper case file extensions should be treated the same as lower case when decrypting
Testing, NormalPublic
Actions

Description

If I encrypt a file and change the last extension ".gpg" to ".GPG" or ".PGP" in the process, I expect the same behavior as if I had not changed the extension or changed it to ".pgp". That is that ".gpg" or ".pgp" are stripped, leaving the extension before them as last extension, e.g. ".txt":

Instead the file is classified as renamed even though only the ending was changed and “.out” is added to the filename:

Note that in contrast to the first case, the file is now classified as "renamed" although only the last extension changed.

Details

External Link
https://forum.gnupg.org/t/why-does-kleopatra-add-out-extension-to-the-decrypted-filename
Version
Gpg4win 4.4.1

Revisions and Commits

rLIBKLEO Libkleo
rLIBKLEO737e5844bf3b Make classification by suffix case-insensitive
rLIBKLEO3e5462f38090 Split MIME file-related tests and use data-driven testing
rLIBKLEO05eaeaf86bdf Make check for .p7m suffix in isMailFile case-insensitive
rLIBKLEO1a28536b60c4 Simplify tests for Kleo::outputFileName and use data driven testing
rLIBKLEOc9beebb602a0 Make lookup of classification case-insensitive for output file name

Event Timeline

• ebo triaged this task as Normal priority.Fri, Aug 15, 12:04 PM
• ebo created this task.
• ebo created this object with edit policy "Contributor (Project)".
• ikloecker claimed this task.Mon, Aug 18, 11:49 AM
• ikloecker moved this task from Backlog to WIP on the gpd5x board.
• ikloecker added a commit: rLIBKLEOc9beebb602a0: Make lookup of classification case-insensitive for output file name.Mon, Aug 18, 1:18 PM
• ikloecker added a commit: rLIBKLEO1a28536b60c4: Simplify tests for Kleo::outputFileName and use data driven testing.
• ikloecker added a commit: rLIBKLEO05eaeaf86bdf: Make check for .p7m suffix in isMailFile case-insensitive.
• ikloecker added a commit: rLIBKLEO3e5462f38090: Split MIME file-related tests and use data-driven testing.
• ikloecker added a commit: rLIBKLEO737e5844bf3b: Make classification by suffix case-insensitive.
• ikloecker changed the task status from Open to Testing.Mon, Aug 18, 3:11 PM

Fixed.

I've also fixed the problem that a file named mail.P7M was not treated as encrypted email message. I think this could be tested/verified.

Moreover, I have fixed the problem that classification by filename suffix wasn't case insensitive, but since this is just a fallback in case classification by content fails I'm not sure how relevant that is, e.g. a signature file named verify-me.txt.SIG was recognized as signature for verify-me.txt even before my changes.

In any case, filenames with upper-case letters in the suffix should not cause any problems anymore.

• ikloecker mentioned this in Unknown Object (Maniphest Task).Mon, Aug 25, 9:59 AM
timegrid moved this task from WIP to Done on the gpd5x board.Mon, Sep 8, 5:11 PM
timegrid added a subscriber: timegrid.

Looks good to me on gpg4win-5.0.0-beta369 @ win10:

PGP
GPG
P7M
P7S