Kleopatra: Pressing Enter when "Show Audit Log" button has focus unexpectedly triggers "Save All" button
Open, NormalPublic

Assigned To
Authored By
ikloecker
Wed, Sep 9, 10:44 AM

Description

After successful decryption the window showing the result has a "Save All" button and (usually) a "Show Audit Log" button for the decryption.

Press Tab until the "Show Audit Log" button has focus. Then press Enter.

Expected result:
Nothing happens. (Ideally Enter would trigger the focused button, but that's out of scope of this ticket. See T6110: Kleopatra: All buttons shall be activatable with the Enter/Return key.)

Actual result:
Save All is triggered.

The screenshot shows that the "Show Audit Log" button has the focus frame but the "Save All" button is painted as default button. Pressing Space triggers the former button while pressing Enter triggers the latter.

Event Timeline

ikloecker created this task.
ikloecker changed the task status from Open to Testing.EditedWed, Sep 9, 2:01 PM
ikloecker moved this task from Backlog to WIP on the gpd5x board.

Fixed by making sure that "Save All" is never the default button.

The downside of this fix is that one cannot simply press Enter anymore to save the results. Instead one has to focus the Save All button and then press Space. (One can also use the shortcut Alt+S.)

ikloecker changed the task status from Testing to Open.Wed, Sep 9, 5:23 PM

I'm working on a better fix which avoids the downside as much as reasonable.