Page MenuHome GnuPG
Create Task
Maniphest T995

Dead code in gcry_mpi_scan
Closed, InvalidPublic
Actions

Description

When format == GCRYMPI_FMT_SSH, len is set to 0 and then you have code :

if (len && len < 4)
  return gcry_error (GPG_ERR_TOO_SHORT);

and

if (len)
  len -= 4;
if (len && n > len)
  return gcry_error (GPG_ERR_TOO_LARGE);

which is deadcode as len is always 0

Details

Version
1.4.4

Event Timeline

pterjan added projects: libgcrypt, Bug Report.Feb 2 2009, 10:50 PM
pterjan set Version to 1.4.4.
pterjan added a subscriber: pterjan.
• werner added a subscriber: • werner.Feb 3 2009, 9:30 AM

Let the compiler remove it. I added this comment:

/* This test is not strictly necessary and an assert (!len)
   would be sufficient.  We keep this test in case we later
   allow the BUFLEN argument to act as a sanitiy check.  Same
   below. */
• werner closed this task as Invalid.Feb 3 2009, 9:30 AM
• werner removed a project: Bug Report.
pterjan added a comment.Feb 3 2009, 9:42 AM

That's fine, I am always worried when seeing such dead code that the logic at
this place became wrong

• werner added a comment.Feb 4 2009, 9:04 AM

Right, such code should have a comment or use an assert instead. Thanks.