Page MenuHome GnuPG
Differential D581

qt: Parent window on wayland
AbandonedPublic
Actions

Authored by • TobiasFella on Jan 23 2024, 11:17 AM.

Details

Reviewers
• ikloecker
Summary
  • configure.ac: Setup KWindowSystem dependency.
  • qt/main.cpp: Set parent window when on wayland.

This uses KWindowSystem for parenting the window; the dependency is optional. An alternative approach without KWindowSystem would require depending directly on QtWayland tools and QtWayland private API.

Test Plan

Test in combination with https://invent.kde.org/pim/kleopatra/-/merge_requests/98 and GnuPG built from the 2.4 branch

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

• TobiasFella requested review of this revision.Jan 23 2024, 11:17 AM
• TobiasFella created this revision.
CarlSchwan added a subscriber: CarlSchwan.Jan 23 2024, 11:42 AM

Can't comment on the autogen code, but the cpp code looks good

• ikloecker requested changes to this revision.Jan 23 2024, 1:14 PM
• ikloecker added inline comments.
configure.ac
561

Only do this if pinentry_qt6 is built.

669

Remove "-fpic".

This revision now requires changes to proceed.Jan 23 2024, 1:14 PM
• TobiasFella updated this revision to Diff 1577.Jan 23 2024, 1:46 PM
• TobiasFella marked an inline comment as done.
• ikloecker added a comment.Jan 23 2024, 2:23 PM

Ship it!

• TobiasFella abandoned this revision.Jan 23 2024, 2:27 PM

Merged. For some reason i can't close it, so I'll abandon it instead...

• ikloecker added a comment.Jan 23 2024, 5:13 PM
In D581#6137, @TobiasFella wrote:

Merged. For some reason i can't close it, so I'll abandon it instead...

Maybe because I didn't accept it after you addressed my requests for changes.

Revision Contents
Changeset List

PathSize
26 lines
qt/
27 lines

Diff 1577

View Options

configure.ac

Loading...
View Options

qt/main.cpp

Loading...