jf (Jan Friedel)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Mar 27 2017, 4:48 PM (89 w, 2 d)
Availability
Available

Recent Activity

Jul 26 2016

jf added a comment to T2378: t-lock and random tests crash on SPARC 32-bit.

IMHO, it's pretty uncommon from the packaging point of view to deliver
different generic header files for different platforms (one can meet
platform related ifdefs much often). It necessarily moves the platform
decision rules into the source code of the library consumer.

Jul 26 2016, 7:00 PM · Not A Bug, gpgrt, Bug Report

Jun 15 2016

jf added a comment to T2378: t-lock and random tests crash on SPARC 32-bit.

Note: the comment 2) in T2378 (jf on Jun 04 2016, 07:04 PM / Roundup) [https://bugs.gnupg.org/gnupg/msg8416]
is not correct. The original text says:

    • 8< ---
  1. the fix updates only the external gpgrt_lock_t; it's internal

counterpart _gpgrt_lock_t is not updated. This causes that functions
working with the POSIX mutexes (gpgrt_lock_*()) could access misaligned
addresses - that results in Bus Errors on SPARC.

  • 8< ---

The fact is that _gpgrt_lock_t already contains pthread_mutex_t thus it
is correctly aligned (alignes on 8B boundary). The problem pops up if
the outer gpgrt_lock_t is aligned on 4 bytes boundary, while the
internal _gpgrt_lock_t in aligned on 8 bytes.

Jun 15 2016, 9:24 AM · Not A Bug, gpgrt, Bug Report
jf added a comment to T2378: t-lock and random tests crash on SPARC 32-bit.

Please, find below the preliminary suggested fix:

  • ./src/gen-posix-lock-obj.c.orig Mon Jun 13 08:07:53 2016

+++ ./src/gen-posix-lock-obj.c Mon Jun 13 08:08:40 2016
@@ -42,21 +42,8 @@
#endif
#endif

-/* Special requirements for certain platforms. */

  • define USE_LONG_DOUBLE_FOR_ALIGNMENT 0

-#if defined(sun) && !defined (LP64__) && !defined(_LP64)
-/* Solaris on 32-bit architecture. */

  • define USE_DOUBLE_FOR_ALIGNMENT 1

-#else

  • define USE_DOUBLE_FOR_ALIGNMENT 0

-#endif
-#if defined(hppa)

  • define USE_16BYTE_ALIGNMENT 1

-#else

  • define USE_16BYTE_ALIGNMENT 0

-#endif

-#if USE_16BYTE_ALIGNMENT && !HAVE_GCC_ATTRIBUTE_ALIGNED
+#if defined(hppa) && !HAVE_GCC_ATTRIBUTE_ALIGNED

  1. error compiler is not able to enforce a 16 byte alignment #endif

@@ -122,12 +109,14 @@

"\n"
"#define GPGRT_LOCK_INITIALIZER {%d,{{",
SIZEOF_PTHREAD_MUTEX_T,
  • if USE_16BYTE_ALIGNMENT

+/* Special requirements for certain platforms. */
+# ifdef (hppa)

"    int _x16_align __attribute__ ((aligned (16)));\n",
    • elif USE_DOUBLE_FOR_ALIGNMENT
  • " double _xd_align;\n",
    • elif USE_LONG_DOUBLE_FOR_ALIGNMENT
  • " long double _xld_align;\n",

+# elif defined(sun)
+ "#if (defined(
sparc) || defined(sparc)) && \\\n"
+ " !defined (LP64) && !defined(_LP64)\n"
+ " double _xd_align;\n"
+ "#endif\n",

  1. else "",
  2. endif
Jun 15 2016, 9:18 AM · Not A Bug, gpgrt, Bug Report

Jun 4 2016

jf added a comment to T2378: t-lock and random tests crash on SPARC 32-bit.

D375: 844_20_posix-lock-obj.patch

Jun 4 2016, 7:47 PM · Not A Bug, gpgrt, Bug Report
jf added a comment to T2378: t-lock and random tests crash on SPARC 32-bit.

Debugging a bit more in the source code suggests, that the problem could
be still related to the misalignment resolved in the bug 2144 [1].

There seem to be two problems with the fix [2].

  1. the fix causes that two identical gpg-error.h header files could be

generated based on what the current compilation target platform is,
32/64bit. Instead of generating two distinct header files, only one
header file should be generated (or better to say, the
gen-posix-lock-obj can be called twice - once for 32bit platform, once
for the 64-bit one, but it should always return the same content).
The particular decision whether the alignment item will be added to the
struct should be solved in the header file - not at the header file
generation time. In that case, the decision whether the alignment item
is added will be made at the libgpg-error consumer's compilation time
(like libgcrypt).

  1. the fix updates only the external gpgrt_lock_t; it's internal

counterpart _gpgrt_lock_t is not updated. This causes that functions
working with the POSIX mutexes (gpgrt_lock_*()) could access misaligned
addresses - that results in Bus Errors on SPARC.

Referecences:
[1] T2144
[2]
https://git.gnupg.org/cgi-bin/gitweb.cgi?p=libgpg-error.git;a=commit;h=f7a77c5c236ecec846de9be46703026f9b01008f

Jun 4 2016, 7:04 PM · Not A Bug, gpgrt, Bug Report
jf removed Version on T2378: t-lock and random tests crash on SPARC 32-bit.
Jun 4 2016, 7:04 PM · Not A Bug, gpgrt, Bug Report
jf added a project to T2378: t-lock and random tests crash on SPARC 32-bit: gpgrt.
Jun 4 2016, 7:04 PM · Not A Bug, gpgrt, Bug Report
jf removed a project from T2378: t-lock and random tests crash on SPARC 32-bit: libgcrypt.
Jun 4 2016, 7:04 PM · Not A Bug, gpgrt, Bug Report
jf renamed T2378: t-lock and random tests crash on SPARC 32-bit from libgcrypt-1.7.0 t-lock test crashes on SPARC 32-bit to t-lock and random tests crash on SPARC 32-bit.
Jun 4 2016, 6:43 PM · Not A Bug, gpgrt, Bug Report
jf set Version to libgcrypt-1.7.0 on T2378: t-lock and random tests crash on SPARC 32-bit.
Jun 4 2016, 6:43 PM · Not A Bug, gpgrt, Bug Report
jf added a comment to T2378: t-lock and random tests crash on SPARC 32-bit.

libgcryp-1.7.0 t-lock and random test cases consistently crash on
SPARCv7 platform. On other platforms like x86/amd64/SPARCv9 the tests
succeed.

  • 8< ---

PASS: t-mpi-point
PASS: curves
/bin/bash: line 5: 6557 Bus Error (core dumped)
GCRYPT_IN_REGRESSION_TEST=1 ${dir}$tst
FAIL: t-lock
PASS: prime

[...]

PASS: fips186-dsa
PASS: aeswrap
PASS: pkcs1v2
random: running './random --in-recursion --early-rng-check' failed
FAIL: random
PASS: dsa-rfc6979

256 of 1026 tests done
512 of 1026 tests done
  • 8< ---
Jun 4 2016, 6:43 PM · Not A Bug, gpgrt, Bug Report

Jun 3 2016

jf added projects to T2378: t-lock and random tests crash on SPARC 32-bit: libgcrypt, Bug Report.
Jun 3 2016, 10:43 PM · Not A Bug, gpgrt, Bug Report

Apr 14 2016

jf added a comment to T2144: libgpg-error: assertion error on Solaris/sparc.

Apr 14 2016, 5:25 PM · Bug Report, gpgrt
jf added a comment to T2144: libgpg-error: assertion error on Solaris/sparc.

The attached is an analysis from the Solaris/SPARC point of view.

One of the possible SPARC specific fixes:

  • ./src/posix-lock-obj.h.orig Wed Apr 13 08:24:20 2016

+++ ./src/posix-lock-obj.h Wed Apr 13 08:24:25 2016
@@ -29,7 +29,7 @@

typedef struct
{

  • long vers;

+ long long vers;
#if USE_POSIX_THREADS

union {
  pthread_mutex_t mtx;
  • ./src/gen-posix-lock-obj.c.orig Wed Apr 13 08:23:59 2016

+++ ./src/gen-posix-lock-obj.c Wed Apr 13 08:24:29 2016
@@ -66,7 +66,7 @@

int i;

#endif

struct {
  • long vers;

+ long long vers;
#ifdef USE_POSIX_THREADS

pthread_mutex_t mtx;

#endif
@@ -105,7 +105,7 @@

   union and include a long and a pointer to a long.  */
printf ("typedef struct\n"
        "{\n"
  • " long _vers;\n"

+ " long long _vers;\n"

"  union {\n"
"    volatile char _priv[%d];\n"
"%s"

@@ -138,7 +138,7 @@

printf ("/* Dummy object - no locking available.  */\n"
        "typedef struct\n"
        "{\n"
  • " long _vers;\n"

+ " long long _vers;\n"

           "} gpgrt_lock_t;\n"
           "\n"
           "#define GPGRT_LOCK_INITIALIZER {%d}\n",

Note, that this was not fully tested on other platforms and might need
additional changes in the header files. I did some minor tests on
Solaris amd64/SPARCv9/SPARCv7, Linux amd64/SPARCv9.

Apr 14 2016, 5:25 PM · Bug Report, gpgrt