PythonUmbrella
ActivePublic

Recent Activity

Aug 27 2019

dkg added a comment to T4276: Context.decrypt() throws an error if *any* signature is bad.

i'm actually running make -j3 check, since make -j3 distcheck has the problems described in T4688.

Aug 27 2019, 4:50 PM · gpgme, Python, Bug Report
dkg added a comment to T4276: Context.decrypt() throws an error if *any* signature is bad.

So i've been able to (intermittently) reproduce the failures that i think @werner was alluding to here, but not under any circumstances where i can get them to happen reliably to understand what's going on.

Aug 27 2019, 4:18 PM · gpgme, Python, Bug Report

Jul 8 2019

dkg added a comment to T4276: Context.decrypt() throws an error if *any* signature is bad.

yes, python2.7 and python3.7

Jul 8 2019, 5:55 PM · gpgme, Python, Bug Report
werner added a comment to T4276: Context.decrypt() throws an error if *any* signature is bad.

Using several python versions?

Jul 8 2019, 9:53 AM · gpgme, Python, Bug Report
dkg reopened T4276: Context.decrypt() throws an error if *any* signature is bad as "Open".

rM7d0a979c07d2 disabled the test for this. @werner says:

Jul 8 2019, 4:38 AM · gpgme, Python, Bug Report

Jun 21 2019

werner triaged T4578: python3 gpg module should offer an "encrypt" function that takes an email.message.EmailMessage and returns a new one as Normal priority.
Jun 21 2019, 10:04 AM · gpgme, Python, Feature Request

Jun 19 2019

dkg added a comment to T4578: python3 gpg module should offer an "encrypt" function that takes an email.message.EmailMessage and returns a new one.

I note that "the best" seems like it might be a pretty subjective thing. The standard GnuPG framing asks about the validity of keys for the User ID in question. Perhaps the caller could indicate whether they want to require full validity for each key to make this key selection more strict.

Jun 19 2019, 7:22 PM · gpgme, Python, Feature Request
dkg added a comment to T4578: python3 gpg module should offer an "encrypt" function that takes an email.message.EmailMessage and returns a new one.

The function would do something like:

  • from msg, extract all e-mail addresses from to, cc, bcc fields
  • find "the best" keys that match these addresses, storing them in keylist
  • copy msg to tmp, remove bcc header from tmp
  • wrap armored output of gpg.Context.encrypt(bytes(tmp), recipients=keylist) in the necessary RFC 3156 cladding, copying most headers from msg (maybe stubbing out the subject), producing an email.message.EmailMessage object.
Jun 19 2019, 7:19 PM · gpgme, Python, Feature Request
dkg created T4578: python3 gpg module should offer an "encrypt" function that takes an email.message.EmailMessage and returns a new one.
Jun 19 2019, 6:59 PM · gpgme, Python, Feature Request

Jun 13 2019

werner added a commit to T4276: Context.decrypt() throws an error if *any* signature is bad: rM7d0a979c07d2: python: Fix regression in t-decrypt-verify test..
Jun 13 2019, 3:36 PM · gpgme, Python, Bug Report

Jun 4 2019

gniibe closed T4478: Please fix DeryptionError typo in gpgme python bindings as Resolved.

I tried to apply&push, since we changed the file a bit, I needed to apply it manually.
Anyway, it's done.
Closing.

Jun 4 2019, 3:42 AM · Python, Bug Report, gpgme
gniibe added a commit to T4478: Please fix DeryptionError typo in gpgme python bindings: rM47135ffdb923: python: Fix typo in DecryptionError exception..
Jun 4 2019, 3:41 AM · Python, Bug Report, gpgme

May 6 2019

aheinecke closed T4276: Context.decrypt() throws an error if *any* signature is bad as Resolved.

Merged. Thanks again for your work on this.

May 6 2019, 8:49 AM · gpgme, Python, Bug Report
dkg added a commit to T4276: Context.decrypt() throws an error if *any* signature is bad: rMbd2d282e572b: python/tests: try to decrypt and verify new test data.
May 6 2019, 8:41 AM · gpgme, Python, Bug Report
dkg added a commit to T4276: Context.decrypt() throws an error if *any* signature is bad: rM4100794e305b: python: stop raising BadSignatures from decrypt(verify=True).
May 6 2019, 8:41 AM · gpgme, Python, Bug Report
aheinecke added a comment to T4276: Context.decrypt() throws an error if *any* signature is bad.

Thanks for the explanation. That addresses my concerns.

May 6 2019, 8:05 AM · gpgme, Python, Bug Report

May 3 2019

dkg added a comment to T4276: Context.decrypt() throws an error if *any* signature is bad.

I agree that this is a minor API shift, but i *don't* think it's a security problem, because i was particularly careful to maintain the invariant that decrypt(verify=True) will only ever return valid signatures.

May 3 2019, 5:23 PM · gpgme, Python, Bug Report
werner triaged T4478: Please fix DeryptionError typo in gpgme python bindings as High priority.
May 3 2019, 10:29 AM · Python, Bug Report, gpgme
werner added a project to T4478: Please fix DeryptionError typo in gpgme python bindings: Python.
May 3 2019, 10:29 AM · Python, Bug Report, gpgme
aheinecke added a comment to T4276: Context.decrypt() throws an error if *any* signature is bad.

I'm for merging this as I understand the rationale. In Kleo / GpgOL I also only need one valid signature.

May 3 2019, 8:35 AM · gpgme, Python, Bug Report
dkg added a comment to T4276: Context.decrypt() throws an error if *any* signature is bad.

I've just published a branch dkg/fix-T4276 (with commit 4100794e305ba22241ea5a4f7b42bb5189fbd948) which i think resolves this issue.

May 3 2019, 6:49 AM · gpgme, Python, Bug Report

Mar 19 2019

aheinecke added a comment to T4276: Context.decrypt() throws an error if *any* signature is bad.

@dkg If you propose a patch here I'm pretty sure that we will accept it. As one of our Python binding users you know better then us how the API should behave.

Mar 19 2019, 3:51 PM · gpgme, Python, Bug Report
werner triaged T4276: Context.decrypt() throws an error if *any* signature is bad as Normal priority.
Mar 19 2019, 1:44 PM · gpgme, Python, Bug Report

Mar 12 2019

bernhard added a comment to T3505: Port GPGME's Python bindings to Windows.

Reading through this issue and the related documentation: Thanks for writing this all down and adding links!

Mar 12 2019, 5:50 PM · Feature Request, gpgme, Python

Jan 9 2019

aheinecke closed T3815: tests fail in 2021 as Resolved.

I sent a message to gnupg-devel about this issue as it will probably hit more people now that the keys used are expired :-(

Jan 9 2019, 8:52 AM · qt, Python, gpgme, Bug Report
aheinecke added a commit to T3815: tests fail in 2021: rM66376f3e206a: qt: Use tofu conflict test keys without expiry.
Jan 9 2019, 8:46 AM · qt, Python, gpgme, Bug Report
aheinecke added a comment to T3815: tests fail in 2021.

Oh,.. it is even worse. The conflict keys expired 2019-01-06 so they are actually expired right now.

Jan 9 2019, 8:18 AM · qt, Python, gpgme, Bug Report
aheinecke claimed T3815: tests fail in 2021.
Jan 9 2019, 8:12 AM · qt, Python, gpgme, Bug Report
werner reopened T3815: tests fail in 2021 as "Open".

I don't know why @BenM closed this bug given that he mentioned that the qt part is yet not solved.

Jan 9 2019, 8:00 AM · qt, Python, gpgme, Bug Report

Jan 8 2019

hedning added a comment to T3815: tests fail in 2021.

We've run into the testTofuConflict failure on NixOS. gpgme v1.12, gnupg v2.2.12.

Jan 8 2019, 8:05 PM · qt, Python, gpgme, Bug Report

Dec 15 2018

BenM added a comment to T3505: Port GPGME's Python bindings to Windows.

Though not directly related to our issues, this bug report on the MSYS2 site reported by their users encountering trouble with GPGME provides additional weight to irreconcilable differences between MSYS2 and GnuPG:

Dec 15 2018, 8:18 PM · Feature Request, gpgme, Python

Dec 10 2018

BenM closed T3815: tests fail in 2021 as Resolved.

Though apparently resolved back in May, this is what ultimately led to T4191 and was thus only properly resolved quite recently.

Dec 10 2018, 6:19 AM · qt, Python, gpgme, Bug Report
BenM closed T4271: python gpg.Context.decrypt(verify=False) no longer works as Resolved.

Confirmed that this is indeed fixed and made the (rather minor) change to the HOWTO that was needed. No changes were needed for the example script (decrypt-file.py).

Dec 10 2018, 6:08 AM · Python, gpgme, Bug Report
BenM closed T4191: gpgme python bindings test t-callbacks.py fails on 32-bit platforms as Resolved.

This has now been tested on a 32-bit Gentoo VM and it behaves as expected with 32-bit system detection and creating keys with pre-2038 expirations working.

Dec 10 2018, 4:51 AM · Python, gpgme, Bug Report

Dec 8 2018

BenM updated subscribers of T3505: Port GPGME's Python bindings to Windows.

Commit 8613727f1ee985c3cfa2c815523312914f033ffd adds considerable detail on both the issues affecting compiling and installing a Windows version of the bindings and what it would take to actually resolve it.

Dec 8 2018, 7:02 AM · Feature Request, gpgme, Python

Dec 6 2018

BenM added a comment to T4191: gpgme python bindings test t-callbacks.py fails on 32-bit platforms.

I'll deploy one on AWS somewhere briefly once I've replaced a certain external keyboard, there will almost certainly be an existing image of some Linux distro in the AWS marketplace and I'd be very surprised if it took more than an hour or two of compute time to confirm.

Dec 6 2018, 2:50 PM · Python, gpgme, Bug Report

Dec 5 2018

dkg added a comment to T4276: Context.decrypt() throws an error if *any* signature is bad.

One more semantic question about how folks think Context.decrypt(verify=True) should work: if the decrypted thing has no signature at all, should the function succeed without throwing an exception? it currently does, but the returned verify_result has its signatures member set to the empty list.

Dec 5 2018, 6:30 PM · gpgme, Python, Bug Report
BenM added a comment to T4271: python gpg.Context.decrypt(verify=False) no longer works.

Ooh, nice catch @dkg, I just stepped through each of your changes and it all looks good. I'll tweak the relevant sections of the HOWTO dealing with this in the next few days (I need to replace a keyboard here before properly diving back in) and then close this case once done.

Dec 5 2018, 4:14 PM · Python, gpgme, Bug Report
dkg added a comment to T4271: python gpg.Context.decrypt(verify=False) no longer works.

since @aheinecke merged my changes, i think this bug is now resolved. I'll let @BenM close it though :)

Dec 5 2018, 2:06 PM · Python, gpgme, Bug Report
dkg added a comment to T4276: Context.decrypt() throws an error if *any* signature is bad.

@aheinecke thanks for the merge of my other branch! sadly, that branch does *not* address this issue yet. It doesn't even test for it. :( I can work on trying to fix it (and test it) if there's a consensus that we want this particular change in behavior.

Dec 5 2018, 2:04 PM · gpgme, Python, Bug Report
aheinecke added a comment to T4276: Context.decrypt() throws an error if *any* signature is bad.

Is this fixed now?

Dec 5 2018, 11:54 AM · gpgme, Python, Bug Report
aheinecke added a commit to T4271: python gpg.Context.decrypt(verify=False) no longer works: rM65c28da4e49a: python: overhaul logic of Context.decrypt().
Dec 5 2018, 11:50 AM · Python, gpgme, Bug Report
aheinecke changed the status of T4271: python gpg.Context.decrypt(verify=False) no longer works from Open to Testing.

Ben is not even subscribed to this issue.
With the volatility of gpgme-python I think that this can easily be merged. I did a quick review and it looked good to me.

Dec 5 2018, 11:49 AM · Python, gpgme, Bug Report
werner added a comment to T4271: python gpg.Context.decrypt(verify=False) no longer works.

Needs to be merged. (Note that Phabricator does not show the branch in the tooltip for commit ids.)

Dec 5 2018, 10:44 AM · Python, gpgme, Bug Report
dkg added a comment to T4271: python gpg.Context.decrypt(verify=False) no longer works.

note that the branch also updates the test suite to make sure the verify=False case is tested.

Dec 5 2018, 6:34 AM · Python, gpgme, Bug Report
dkg created T4276: Context.decrypt() throws an error if *any* signature is bad.
Dec 5 2018, 6:18 AM · gpgme, Python, Bug Report
dkg added a commit to T4271: python gpg.Context.decrypt(verify=False) no longer works: rMac8d7238dbf1: python: overhaul logic of Context.decrypt().
Dec 5 2018, 12:51 AM · Python, gpgme, Bug Report
dkg added a comment to T4271: python gpg.Context.decrypt(verify=False) no longer works.

I've just pushed a branch dkg/fix-T4271 , currently at ac8d7238dbf165950c9844e5cb41da8eb4d37bc0 that resolves this problem.

Dec 5 2018, 12:51 AM · Python, gpgme, Bug Report

Nov 28 2018

werner triaged T4271: python gpg.Context.decrypt(verify=False) no longer works as Unbreak Now! priority.

Regression introduced with 1.12.0.

Nov 28 2018, 9:30 AM · Python, gpgme, Bug Report

Nov 27 2018

dkg added a comment to T4271: python gpg.Context.decrypt(verify=False) no longer works.

please add a unit to the test suite to make sure something like this doesn't happen in the future!

Nov 27 2018, 10:14 PM · Python, gpgme, Bug Report