Home GnuPG

Filter out some Clover coverage to prevent false positives
086f5399bfbbUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Filter out some Clover coverage to prevent false positives

Summary: Clover reports generated from PHPUnit sometimes give false positives of lines that were not covered by a test that should have actually been not coverable, apparently due to inaccurate static analysis of files that weren't actually executed. This filters coverage reports of files that show no coverage which avoids these false positives. Fixes T10420.

Test Plan:
Looked at coverage reports of files before and after the change

Before: {F1124115}

After: {F1124113}

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, aurelijus

Maniphest Tasks: T10420

Differential Revision: https://secure.phabricator.com/D15343

Details

Provenance
Eric Stern <eric@ericstern.com>Authored on Feb 24 2016, 9:48 PM
Parents
rARCfcc11b3a2781: Add --quiet to `git fetch` on `arc land`
Branches
Unknown
Tags
Unknown

Event Timeline

Eric Stern <eric@ericstern.com> committed rARC086f5399bfbb: Filter out some Clover coverage to prevent false positives (authored by Eric Stern <eric@ericstern.com>).Feb 24 2016, 9:58 PM