Minor fix for typecast linter rule
09052d52470dUnpublished
Actions

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Minor fix for typecast linter rule

Summary: intval($x, $y) cannot be safely changed to (int)$x if $y != 10.

Test Plan: Added test cases.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14611

Details

Provenance

Joshua Spence <josh@freelancer.com>

Authored on Dec 2 2015, 4:12 AM

Parents

rARC00efcd294fd0: Add a linter rule for hexadecimal number casing

Branches

Unknown

Tags

Unknown

Event Timeline

Joshua Spence <josh@freelancer.com> committed rARC09052d52470d: Minor fix for typecast linter rule (authored by Joshua Spence <josh@freelancer.com>).Dec 2 2015, 4:12 AM

Changes (2)

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule.php

__tests__/

function-call-should-be-type-cast/

base.lint-test

rARC09052d52470d

View Options

src/lint/linter/xhpast/rules/ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule.php