Home GnuPG

Fix a fatal error in `ArcanistXHPASTLinter`
13492c8043a4Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Fix a fatal error in ArcanistXHPASTLinter

Summary: I had assumed that we would always be interested in n_STATEMENT_LIST, which is fine for if (...) { some_statements(); } but not for if (...) one_statement();.

Test Plan: Added a test case.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D10551

Details

Provenance
Joshua Spence <josh@joshuaspence.com>Authored on Sep 24 2014, 11:33 PM
Parents
rARC888ada2f380c: Improve `LINT_DOS_NEWLINE` behavior
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rARC13492c8043a4: Fix a fatal error in `ArcanistXHPASTLinter` (authored by Joshua Spence <josh@joshuaspence.com>).Sep 24 2014, 11:33 PM