Home GnuPG

Add a linter rule for `abstract private` methods
20e99acf0ad1Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Add a linter rule for abstract private methods

Summary:
Methods cannot be marked as both abstract and private. This language construct will cause a fatal error:

PHP Fatal error:  Abstract function X::Y() cannot be declared private in /home/josh/workspace/github.com/phacility/arcanist/test.php on line 4

Test Plan: Added unit tests.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14558

Details

Provenance
Joshua Spence <josh@freelancer.com>Authored on Nov 23 2015, 10:18 PM
Parents
rARC6f908f633b7f: Add a linter rule for unnecessary symbol aliases
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@freelancer.com> committed rARC20e99acf0ad1: Add a linter rule for `abstract private` methods (authored by Joshua Spence <josh@freelancer.com>).Nov 23 2015, 10:18 PM