Home GnuPG

Properly URL encode branches in `arc browse --branch ...`
3876d9358390Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Properly URL encode branches in arc browse --branch ...

Summary: Fixes T10511. If you arc browse --branch x/y/z, we do not encode the URI properly.

Test Plan:
Ran arc browse --branch x/y/z/ something.c.

Before, got an error about "x" does not exist. This is wrong; the error should be about "x/y/z".

After, got the proper error:

{F1141096}

Reviewers: chad, avivey

Reviewed By: avivey

Maniphest Tasks: T10511

Differential Revision: https://secure.phabricator.com/D15397

Details

Provenance
epriestley <git@epriestley.com>Authored on Mar 5 2016, 12:49 AM
Parents
rARCb1de04aa6836: Report unit test details from Arcanist to Harbormaster
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rARC3876d9358390: Properly URL encode branches in `arc browse --branch ...` (authored by epriestley <git@epriestley.com>).Mar 5 2016, 12:52 AM