Home GnuPG

Update xhpast linter rules for new function AST format
3ffed59bd7fbUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Update xhpast linter rules for new function AST format

Summary: See D15678. A node containing a return type hint is added right before the statement body node. This updates all relevant linter rules to now retrieve the body from the correct index.

Test Plan: Ran arc unit --everything, inspected every single message to make sure all xhpast test cases succeeded. Also grepped for getChildByIndex(5 and getChildOfType(5.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15814

Details

Provenance
Richard van Velzen <rvanvelzen@experty.com>Authored on Apr 28 2016, 4:59 PM
Parents
rARCea6fc7789295: Fix incorrect variable for linter standards
Branches
Unknown
Tags
Unknown

Event Timeline

Richard van Velzen <rvanvelzen@experty.com> committed rARC3ffed59bd7fb: Update xhpast linter rules for new function AST format (authored by Richard van Velzen <rvanvelzen@experty.com>).Apr 29 2016, 2:38 PM