Home GnuPG

Use EditDistanceMatrix diff smoothing in Arcanist
41e8e30e8c13Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Use EditDistanceMatrix diff smoothing in Arcanist

Summary:
Ref T7643. We've done the smoothing from D16068 for a long time, it just wasn't part of EditDistanceMatrix.

Since it now is, call it instead of keeping a copy of the logic around.

Previously, the unit tests were testing un-smoothed diffs. Just have them test smoothed diffs instead, since nothing actually uses unsmoothed diffs.

Test Plan: Pasted a raw diff into the web UI, got a sensible inline diff for it.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T7643

Differential Revision: https://secure.phabricator.com/D16069

Details

Provenance
epriestley <git@epriestley.com>Authored on Jun 7 2016, 5:22 PM
Parents
rARCca3324094259: Don't specify size 0 for deleted files
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rARC41e8e30e8c13: Use EditDistanceMatrix diff smoothing in Arcanist (authored by epriestley <git@epriestley.com>).Jun 7 2016, 6:13 PM