Home GnuPG
Diffusion Arcanist 4404e66735c4

Improve the "inline HTML" linter rule
4404e66735c4Unpublished
Actions

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Improve the "inline HTML" linter rule

Summary: Improve ArcanistInlineHTMLXHPASTLinterRule such that it doesn't raise duplicate warnings. Also be a bit more lax with whitespace.

Test Plan: Unit tests now pass.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D13896

Details

Provenance
Joshua Spence <josh@joshuaspence.com>Authored on Aug 19 2015, 7:34 AM
Joshua Spence <josh@freelancer.com>Committed on Aug 19 2015, 7:34 AM
Parents
rARCfe8ed2a6f8b0: Add a linter rule for the use of `parse_str`
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@freelancer.com> committed rARC4404e66735c4: Improve the "inline HTML" linter rule (authored by Joshua Spence <josh@joshuaspence.com>).Aug 19 2015, 7:34 AM

Changes (3)

PathSize
src/
lint/
linter/
__tests__/
xhpast/

rARC4404e66735c4

View Options

src/lint/linter/ArcanistInlineHTMLXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/embedded-tags.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/php-tags-bad.lint-test

Loading...