Home GnuPG

Validate Arcanist install-certificate URIs more carefully
4d4d16f25985Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Validate Arcanist install-certificate URIs more carefully

Summary: Fixes T11222. This was lazy-future-proofed for Conduit SSH support, but users are boundlessly creative. Check protocols explicitly.

Test Plan:

$ arc install-certificate a.b:1/
Usage Exception: Server URI "a.b:1/" must include the "http" or "https" protocol. It should be in the form "https://phabricator.example.com/".
  • Also went through a successful workflow with a URI in the form provided in the example.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11222

Differential Revision: https://secure.phabricator.com/D16188

Details

Provenance
epriestley <git@epriestley.com>Authored on Jun 28 2016, 11:43 PM
Parents
rARC2374403e8f80: Remove the "you have not specified reviewers" prompt from the `arc` client
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rARC4d4d16f25985: Validate Arcanist install-certificate URIs more carefully (authored by epriestley <git@epriestley.com>).Jun 29 2016, 12:20 AM