Home GnuPG

Move `LINT_NO_COMMIT` from `ArcanistTextLinter` to a new linter
4e3df805844cUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Move LINT_NO_COMMIT from ArcanistTextLinter to a new linter

Summary: I don't feel that this linter rule belongs in the ArcanistTextLinter. In fact, this linter rule is quite similar to the rules provided by ArcanistGeneratedLinter and ArcanistNoLintLinter and these classes could possibly be consolidated. I have moved this linter rule to a standalone ArcanistCommitLinter class (which could possibly do additional lints in the future).

Test Plan: Moved existing test cases.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D10473

Details

Provenance
Joshua Spence <josh@joshuaspence.com>Authored on Jan 4 2015, 6:20 AM
Parents
rARC821ebcdd0727: `pht`ize some strings
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rARC4e3df805844c: Move `LINT_NO_COMMIT` from `ArcanistTextLinter` to a new linter (authored by Joshua Spence <josh@joshuaspence.com>).Jan 4 2015, 6:20 AM