Home GnuPG

Minor improvement for array value linter rule
504ff4268188Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Minor improvement for array value linter rule

Summary:
This linter rule fails on multi-line arrays with no whitespace before the first array value. Specifically, the following exception is thrown:

Fatal error: Call to a member function isAnyWhitespace() on boolean in arcanist/src/lint/linter/xhpast/rules/ArcanistArrayValueXHPASTLinterRule.php on line 40

Test Plan: Added another test case.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D13856

Details

Provenance
Joshua Spence <josh@joshuaspence.com>Authored on Aug 10 2015, 11:55 PM
Parents
rARC830bcbc2a5e9: Add a linter rule for array elements
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rARC504ff4268188: Minor improvement for array value linter rule (authored by Joshua Spence <josh@joshuaspence.com>).Aug 10 2015, 11:55 PM