Home GnuPG
Diffusion Arcanist 581829a99ee8

Write a linter rule for `$this` reassignment
581829a99ee8Unpublished
Actions

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Write a linter rule for $this reassignment

Summary: Re-assigning $this is an invalid PHP construct, see https://3v4l.org/TauX9.

Test Plan: Added unit tests.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14514

Details

Provenance
Joshua Spence <josh@freelancer.com>Authored on Nov 19 2015, 8:50 PM
Parents
rARC426d535b13d7: Fix PHP compatibility linter after improvements to parsing of `use` statements
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@freelancer.com> committed rARC581829a99ee8: Write a linter rule for `$this` reassignment (authored by Joshua Spence <josh@freelancer.com>).Nov 19 2015, 8:50 PM

Changes (6)

PathSize
src/
lint/
linter/
xhpast/
rules/
__tests__/
this-reassignment/
unexpected-return-value/
class.lint-test
empty-return.lint-test
xhpast/
rules/
__tests__/
this-reassignment/
__tests__/
xhpast/
this.lint-test
syntax-error.lint-test

rARC581829a99ee8

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistThisReassignmentXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistThisReassignmentXHPASTLinterRuleTestCase.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/this-reassignment/class.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/this-reassignment/this.lint-test

Loading...