Home GnuPG

Add ArcanistRaggedClassTreeEdgeXHPASTLinterRule to Phutil linter map
5d0f5afca8cdUnpublished

Unpublished Commit ยท Learn More

Publishing Disabled: All publishing is disabled for this repository.

Description

Add ArcanistRaggedClassTreeEdgeXHPASTLinterRule to Phutil linter map

Summary: Fixes T12555.

Test Plan:
Added this class to the codebase and ran arc liberate:

<?php

class FooBar {
    public static function doTheFoo() {
        return 'foobar';
    }
}

Ran arc lint and observed this warning:

Warning  (XHP87) Class Not `abstract` Or `final`
 This class is neither `final` nor `abstract`, and does not have a
 docblock marking it `@concrete-extensible`.

            1 <?php
            2
 >>>        3 class FooBar {
            4     public static function doTheFoo() {
            5         return "foobar";
            6     }

Added a final modifier to FooBar's declaration and observed the warning went away.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T12555

Differential Revision: https://secure.phabricator.com/D17787

Details

Provenance
Austin McKinley <austin@phacility.com>Authored on Apr 25 2017, 1:12 AM
marcusPushed on May 11 2017, 7:34 PM
Parents
rARC146693307f60: Make exception reporting from `arc` be in red
Branches
Unknown
Tags
Unknown

Event Timeline

Austin McKinley <austin@phacility.com> committed rARC5d0f5afca8cd: Add ArcanistRaggedClassTreeEdgeXHPASTLinterRule to Phutil linter map (authored by Austin McKinley <austin@phacility.com>).Apr 25 2017, 7:58 PM