Home GnuPG

Add a linter rule for `parent` references
7386afc953e0Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Add a linter rule for parent references

Summary:
Add a linter rule to detect static method calls which should reference the parent class instead of a hardcoded class reference. For example, consider the following:

class SomeClass extends AnotherClass {
  public function someMethod() {
    AnotherClass::someOtherMethod();
  }
}

This should instead be written as:

class SomeClass extends AnotherClass {
  public function someMethod() {
    parent::someOtherMethod();
  }
}

Test Plan: Added unit tests.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D14443

Details

Provenance
Joshua Spence <josh@freelancer.com>Authored on Nov 18 2015, 10:58 PM
Parents
rARC4d512c51d43c: Test XHPAST linter rules in isolation
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@freelancer.com> committed rARC7386afc953e0: Add a linter rule for `parent` references (authored by Joshua Spence <josh@freelancer.com>).Nov 18 2015, 10:58 PM