Home GnuPG

Fix callsites which called libphutil_console_wrap like it were _format
7e677c27eccfUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Fix callsites which called libphutil_console_wrap like it were _format

Summary:
7e2df9a attempted to pht() some strings; unfortunately, it assumed
that some things that were calls to phutil_console_wrap() were
actually calls to phutil_console_format(). This produces errors of
the form:

[2015-07-17 21:17:28] ERROR 2: str_repeat() expects parameter 2 to be long, string given at [/usr/local/libphutil/src/console/format.php:162]
#0 str_repeat(string, string) called at [<phutil>/src/console/format.php:162]
#1 phutil_console_wrap(string, string, string) called at [<arcanist>/scripts/arcanist.php:620]
#2 arcanist_load_libraries(array, boolean, string, ArcanistWorkingCopyIdentity) called at [<arcanist>/scripts/arcanist.php:154]
%s: %s

Provide an additional call to phutil_console_format() when necessary,
or simply append the relevant characters if possible.

Test Plan: Caused a library load error

Reviewers: #blessed_reviewers, epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14053

Details

Provenance
Alex Vandiver <alexmv@dropbox.com>Authored on Sep 3 2015, 9:01 PM
epriestley <git@epriestley.com>Committed on Sep 3 2015, 9:01 PM
Parents
rARC029e5a7c2900: staging repo compatibility for older git versions
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rARC7e677c27eccf: Fix callsites which called libphutil_console_wrap like it were _format (authored by Alex Vandiver <alexmv@dropbox.com>).Sep 3 2015, 9:01 PM