Home GnuPG

Restore default "yes" behavior for lint patch
807057087d65Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Restore default "yes" behavior for lint patch

Summary:
Fixes T9029

See T9029 for more details, but basically at some point phutil_console_confirm
(which takes a $default_no parameter) was refactored to $console->confirm()
which takes a $default parameter with semantics negated..

Test Plan:
Run arc lint on a repository where patch is suggested. Default
option should be "[Y/n]" to accept the patch.

Reviewers: joshuaspence, #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley

Maniphest Tasks: T9029

Differential Revision: https://secure.phabricator.com/D13873

Details

Provenance
Aiden Scandella <ai@uber.com>Authored on Aug 11 2015, 11:49 PM
epriestley <git@epriestley.com>Committed on Aug 11 2015, 11:49 PM
Parents
rARC423e7d238933: Move a test file
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rARC807057087d65: Restore default "yes" behavior for lint patch (authored by Aiden Scandella <ai@uber.com>).Aug 11 2015, 11:49 PM