Home GnuPG
Diffusion Arcanist 8183a458048c

Add a linter rule for `interface` method bodies
8183a458048cUnpublished
Actions

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Add a linter rule for interface method bodies

Summary:
interface methods cannot contain a body. This construct will cause a fatal error:

PHP Fatal error:  Interface function X::Y() cannot contain body in /home/josh/workspace/github.com/phacility/arcanist/test.php on line 4

Test Plan: Added unit tests.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14561

Details

Provenance
Joshua Spence <josh@freelancer.com>Authored on Nov 25 2015, 9:12 PM
Parents
rARC28f5b0ddc6bb: Fix a compatibility issue with `ArcanistUnsafeDynamicStringXHPASTLinterRule`
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@freelancer.com> committed rARC8183a458048c: Add a linter rule for `interface` method bodies (authored by Joshua Spence <josh@freelancer.com>).Nov 25 2015, 9:12 PM

Changes (6)

PathSize
src/
lint/
linter/
xhpast/
rules/
__tests__/
interface-method-body/
abstract-method-body/
body.lint-test
non-abstract.lint-test
interface-method-body/
class-must-be-declared-abstract/
no-body.lint-test
is-not-abstract.lint-test

rARC8183a458048c

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistInterfaceMethodBodyXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistInterfaceMethodBodyXHPASTLinterRuleTestCase.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/interface-method-body/body.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/interface-method-body/no-body.lint-test

Loading...