Paths

Table of Contentst

Diffusion Arcanist 956bfa701c36

Extend from Phobject
956bfa701c36Unpublished
Actions

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Extend from Phobject

Summary: All base classes should extend from Phobject or some other classes. See D13275 for some explanation.

Test Plan: arc unit

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D13281

Details

Provenance

Joshua Spence <josh@joshuaspence.com>

Authored on Jun 15 2015, 7:45 AM

Parents

rARCac8367a884ff: Add a linter rule for extending Phobject

Branches

Unknown

Tags

Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rARC956bfa701c36: Extend from Phobject (authored by Joshua Spence <josh@joshuaspence.com>).Jun 15 2015, 7:47 AM

Changes (36)

Path

Size

src/

__phutil_library_map__.php

configuration/

ArcanistConfiguration.php

ArcanistConfigurationManager.php

ArcanistSettings.php

difference/

ArcanistDiffUtils.php

differential/

ArcanistDifferentialCommitMessage.php

constants/

ArcanistDifferentialRevisionHash.php

ArcanistDifferentialRevisionStatus.php

hgdaemon/

ArcanistHgProxyClient.php

ArcanistHgProxyServer.php

lint/

ArcanistLintMessage.php

ArcanistLintPatcher.php

ArcanistLintResult.php

ArcanistLintSeverity.php

engine/

ArcanistLintEngine.php

linter/

ArcanistLinter.php

xhpast/

ArcanistXHPASTLintNamingHook.php

ArcanistXHPASTLintSwitchHook.php

ArcanistXHPASTLinterRule.php

renderer/

ArcanistLintRenderer.php

parser/

ArcanistBaseCommitParser.php

ArcanistBundle.php

ArcanistCommentRemover.php

ArcanistDiffParser.php

diff/

ArcanistDiffChange.php

ArcanistDiffChangeType.php

ArcanistDiffHunk.php

repository/

api/

ArcanistRepositoryAPI.php

parser/

ArcanistMercurialParser.php

unit/

ArcanistUnitTestResult.php

engine/

ArcanistUnitTestEngine.php

phutil/

PhutilTestCase.php

parser/

ArcanistTestResultParser.php

ArcanistXUnitTestResultParser.php

renderer/

ArcanistUnitRenderer.php

workingcopyidentity/

ArcanistWorkingCopyIdentity.php

rARC956bfa701c36

View Options

src/__phutil_library_map__.php

View Options

src/configuration/ArcanistConfiguration.php

View Options

src/configuration/ArcanistConfigurationManager.php

View Options

src/configuration/ArcanistSettings.php

View Options

src/difference/ArcanistDiffUtils.php

View Options

src/differential/ArcanistDifferentialCommitMessage.php

View Options

src/differential/constants/ArcanistDifferentialRevisionHash.php

View Options

src/differential/constants/ArcanistDifferentialRevisionStatus.php

View Options

src/hgdaemon/ArcanistHgProxyClient.php

View Options

src/hgdaemon/ArcanistHgProxyServer.php

View Options

src/lint/ArcanistLintMessage.php

View Options

src/lint/ArcanistLintPatcher.php

View Options

src/lint/ArcanistLintResult.php

View Options

src/lint/ArcanistLintSeverity.php

View Options

src/lint/engine/ArcanistLintEngine.php

View Options

src/lint/linter/ArcanistLinter.php

View Options

src/lint/linter/xhpast/ArcanistXHPASTLintNamingHook.php

View Options

src/lint/linter/xhpast/ArcanistXHPASTLintSwitchHook.php

View Options

src/lint/linter/xhpast/ArcanistXHPASTLinterRule.php

View Options

src/lint/renderer/ArcanistLintRenderer.php

View Options

src/parser/ArcanistBaseCommitParser.php

View Options

src/parser/ArcanistBundle.php

View Options

src/parser/ArcanistCommentRemover.php

View Options

src/parser/ArcanistDiffParser.php

View Options

src/parser/diff/ArcanistDiffChange.php

View Options

src/parser/diff/ArcanistDiffChangeType.php

View Options

src/parser/diff/ArcanistDiffHunk.php

View Options

src/repository/api/ArcanistRepositoryAPI.php

View Options

src/repository/parser/ArcanistMercurialParser.php

View Options

src/unit/ArcanistUnitTestResult.php

View Options

src/unit/engine/ArcanistUnitTestEngine.php

View Options

src/unit/engine/phutil/PhutilTestCase.php

View Options

src/unit/parser/ArcanistTestResultParser.php

View Options

src/unit/parser/ArcanistXUnitTestResultParser.php

View Options

src/unit/renderer/ArcanistUnitRenderer.php

View Options

src/workingcopyidentity/ArcanistWorkingCopyIdentity.php

Extend from Phobject956bfa701c36UnpublishedActions

Unpublished Commit · Learn More

Description

Details

Event Timeline

Changes (36)

rARC956bfa701c36

src/__phutil_library_map__.php

src/configuration/ArcanistConfiguration.php

src/configuration/ArcanistConfigurationManager.php

src/configuration/ArcanistSettings.php

src/difference/ArcanistDiffUtils.php

src/differential/ArcanistDifferentialCommitMessage.php

src/differential/constants/ArcanistDifferentialRevisionHash.php

src/differential/constants/ArcanistDifferentialRevisionStatus.php

src/hgdaemon/ArcanistHgProxyClient.php

src/hgdaemon/ArcanistHgProxyServer.php

src/lint/ArcanistLintMessage.php

src/lint/ArcanistLintPatcher.php

src/lint/ArcanistLintResult.php

src/lint/ArcanistLintSeverity.php

src/lint/engine/ArcanistLintEngine.php

src/lint/linter/ArcanistLinter.php

src/lint/linter/xhpast/ArcanistXHPASTLintNamingHook.php

src/lint/linter/xhpast/ArcanistXHPASTLintSwitchHook.php

src/lint/linter/xhpast/ArcanistXHPASTLinterRule.php

src/lint/renderer/ArcanistLintRenderer.php

src/parser/ArcanistBaseCommitParser.php

src/parser/ArcanistBundle.php

src/parser/ArcanistCommentRemover.php

src/parser/ArcanistDiffParser.php

src/parser/diff/ArcanistDiffChange.php

src/parser/diff/ArcanistDiffChangeType.php

src/parser/diff/ArcanistDiffHunk.php

src/repository/api/ArcanistRepositoryAPI.php

src/repository/parser/ArcanistMercurialParser.php

src/unit/ArcanistUnitTestResult.php

src/unit/engine/ArcanistUnitTestEngine.php

src/unit/engine/phutil/PhutilTestCase.php

src/unit/parser/ArcanistTestResultParser.php

src/unit/parser/ArcanistXUnitTestResultParser.php

src/unit/renderer/ArcanistUnitRenderer.php

src/workingcopyidentity/ArcanistWorkingCopyIdentity.php

Extend from Phobject
956bfa701c36Unpublished
Actions