Home GnuPG

Don't pass `--quiet` to `coffeelint`
9c07016ee46cUnpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Don't pass --quiet to coffeelint

Summary: This flag doesn't do anything when combined with --reporter=checkstyle.

Test Plan:

> coffeelint *.coffee
  ✗ fail.coffee
     ✗ #1: Class names should be camel cased. class name: boaConstrictor.
  ✓ pass.coffee

✗ Lint! » 1 error and 0 warnings in 2 files

> coffeelint --quiet *.coffee
  ✗ fail.coffee
     ✗ #1: Class names should be camel cased. class name: boaConstrictor.

✗ Lint! » 1 error and 0 warnings in 2 files

> coffeelint --reporter=checkstyle *.coffee
<?xml version="1.0" encoding="utf-8"?>
<checkstyle version="4.3">
<file name="fail.coffee">
<error line="1"
    severity="error"
    message="Class names should be camel cased; context: class name: boaConstrictor"
    source="coffeelint"/>
</file>
</checkstyle>

> coffeelint --reporter=checkstyle --quiet *.coffee
<?xml version="1.0" encoding="utf-8"?>
<checkstyle version="4.3">
<file name="fail.coffee">
<error line="1"
    severity="error"
    message="Class names should be camel cased; context: class name: boaConstrictor"
    source="coffeelint"/>
</file>
</checkstyle>

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11198

Details

Provenance
Joshua Spence <josh@joshuaspence.com>Authored on Jan 4 2015, 8:43 PM
Parents
rARCda02add6c818: Create an `ArcanistExternalLinterTestCase` class
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rARC9c07016ee46c: Don't pass `--quiet` to `coffeelint` (authored by Joshua Spence <josh@joshuaspence.com>).Jan 4 2015, 8:43 PM