Diffusion Arcanist 9e78d15fc0c7

Improve the "unexpected return value" linter rule
9e78d15fc0c7Unpublished
Actions

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Improve the "unexpected return value" linter rule

Summary: Return values within constructors are acceptable if they are within a closure or anonymous function.

Test Plan: Added a test case.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14564

Details

Provenance

Joshua Spence <josh@freelancer.com>

Authored on Nov 23 2015, 11:49 PM

Parents

rARC72d9013d29dc: Add a linter rule for `abstract` methods containing a body

Branches

Unknown

Tags

Unknown

Event Timeline

Joshua Spence <josh@freelancer.com> committed rARC9e78d15fc0c7: Improve the "unexpected return value" linter rule (authored by Joshua Spence <josh@freelancer.com>).Nov 24 2015, 12:01 AM

Changes (2)

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistUnexpectedReturnValueXHPASTLinterRule.php

__tests__/

unexpected-return-value/

closure.lint-test

rARC9e78d15fc0c7

View Options

src/lint/linter/xhpast/rules/ArcanistUnexpectedReturnValueXHPASTLinterRule.php