Home GnuPG
Diffusion Arcanist a5304e472d18

Add a linter rule for newlines after PHP open tags
a5304e472d18Unpublished
Actions

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Add a linter rule for newlines after PHP open tags

Summary: <?php\n\n... is much easier to read than <?php\n.... Depends on D13889 and D13890.

Test Plan: Added unit tests.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D13534

Details

Provenance
Joshua Spence <josh@joshuaspence.com>Authored on Aug 30 2015, 10:49 PM
Joshua Spence <josh@freelancer.com>Committed on Aug 30 2015, 10:49 PM
Parents
rARC10f9c460fa0f: Remove leftover code for "postponed" lint and unit status
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@freelancer.com> committed rARCa5304e472d18: Add a linter rule for newlines after PHP open tags (authored by Joshua Spence <josh@joshuaspence.com>).Aug 30 2015, 10:49 PM

Changes (59)

PathSize
src/
lint/
linter/
__tests__/
xhpast/
invalid-default-parameter.lint-test
invalid-default-paramter.lint-test
xhpast/
rules/

rARCa5304e472d18

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/array-comma.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/array-index.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/blacklisted.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/call-time-pass-by-reference.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/cast-spacing.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/class-name-literal.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/constant-case.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/constructor-parentheses.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/default-parameters.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/double-quote.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/duplicate-key-in-array.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/duplicate-switch-case.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/dynamic-define.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/elseif.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/empty-block-statement.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/empty-statement.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/exit-expression.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/formatted-string.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/global-variables.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/hash-comments.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/implicit-visibility.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/index-function.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/instanceof-operator.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/invalid-default-parameter.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/invalid-default-paramter.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/invalid-modifiers.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/lamba-func-function.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/language-construct-parentheses.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/list-assignment.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/lowercase-functions.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/modifier-ordering.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/naming-conventions.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/newline-after-open-tag.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/no-segfault-on-abstract.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/no-segfault-on-exit.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/nowdoc.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/object-operating-spacing.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/parens-hug-contents.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/php54-incompat.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/preg-quote.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/reused-iterator-reference.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/reused-local.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/semicolon-spacing.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/single-pass-adjacent-patches.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/space-after-control-keywords.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/space-around-more-operators.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/space-around-operators.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/surprising-constructors.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/tautological-expressions.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/tostring-exception.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/unary-postfix-expression-spacing.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/unary-prefix-expression-spacing.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/unnecessary-final-modifier.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/unreasonably-deep-nesting.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/use-of-this-in-static-method.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/variable-variables.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/wrong-concat-operator.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistNewlineAfterOpenTagXHPASTLinterRule.php

Loading...