Home GnuPG

Fix cpplint message regex
aeb374b33348Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Fix cpplint message regex

Summary:
ref T8404

The issue is caused, not by the non-zero return code, but by the fact that
$messages is coming back empty due to the incorrect regex. tyhoff pointed out
that the regex matched correctly when we used STDIN, but now it is failing.

https://secure.phabricator.com/diffusion/ARC/browse/master/src/lint/linter/ArcanistExternalLinter.php;8c589f1f759f0913135b8cc6959a6c1589e14ae4$357

Test Plan:
arc lint cpp file containing lint error. run cpplint on the
file directly to confirm that there are errors and that the return code
is non-zero

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Maniphest Tasks: T8404

Differential Revision: https://secure.phabricator.com/D14960

Details

Provenance
John Allen <john@interana.com>Authored on Jan 6 2016, 10:15 PM
epriestley <git@epriestley.com>Committed on Jan 6 2016, 10:15 PM
Parents
rARC98d71571e444: Fix `arc diff --raw` with "onto" target properties
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rARCaeb374b33348: Fix cpplint message regex (authored by John Allen <john@interana.com>).Jan 6 2016, 10:15 PM