Home GnuPG

Fix ArcanistCSSLintLinter issue for messages without line number
b25cf080bc55Unpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Fix ArcanistCSSLintLinter issue for messages without line number

Summary:
csslint offers some diagnostics related to all the document without any
relevant line number.

In such case, arc lint failed, as setLine expects null or an integer,
but not an empty string.

The 'char' and 'line' attributes in XML report are now optional.

Fixes T9804.

Test Plan: test case to repro the issue added

Reviewers: chad, joshuaspence, #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Maniphest Tasks: T9804

Differential Revision: https://secure.phabricator.com/D14497

Details

Provenance
Sébastien Santoro <dereckson@espace-win.org>Authored on Nov 17 2015, 4:14 PM
epriestley <git@epriestley.com>Committed on Nov 17 2015, 4:14 PM
Parents
rARC66ab1c955d27: Remove arguments from unit test engines
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rARCb25cf080bc55: Fix ArcanistCSSLintLinter issue for messages without line number (authored by Sébastien Santoro <dereckson@espace-win.org>).Nov 17 2015, 4:14 PM