Home GnuPG

Don't give Mercurial empty string as a remote name
b32149495b85Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Don't give Mercurial empty string as a remote name

Summary:
Fixes T9807. We currently run commands like this in some cases:

hg push -r master ''

From T9807, it seems that older Mercurial treated '' in the same way it would treat no argument, while newer Mercurial does not.

Passing '' is unusual and not intended.

Test Plan:
From T9807, @cspeckmim confirmed that running this command without the '' works, and @jgelgens tested the patch itself.

I didn't actually run this code myself, since I don't have Mercurial 3.6.1 installed and the fix seems straightfoward.

Reviewers: chad

Reviewed By: chad

Subscribers: cspeckmim

Maniphest Tasks: T9807

Differential Revision: https://secure.phabricator.com/D14531

Details

Provenance
epriestley <git@epriestley.com>Authored on Nov 18 2015, 6:57 PM
Parents
rARCa77a77817a03: Try switching to the branch of the same name, instead of detached head
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rARCb32149495b85: Don't give Mercurial empty string as a remote name (authored by epriestley <git@epriestley.com>).Nov 21 2015, 6:54 PM