Home GnuPG
Diffusion Arcanist b3e68c9f1793

Add a linter rule for use of `is_a`
b3e68c9f1793Unpublished
Actions

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Add a linter rule for use of is_a

Summary: instanceof should be used instead of is_a. I need to do a bit more research here to see if there are any edge cases.

Test Plan: Added unit tests.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14573

Details

Provenance
Joshua Spence <josh@freelancer.com>Authored on Dec 22 2015, 10:42 PM
Parents
rARC9ee14d28490c: Improve the "self member reference" linter rule
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@freelancer.com> committed rARCb3e68c9f1793: Add a linter rule for use of `is_a` (authored by Joshua Spence <josh@freelancer.com>).Dec 22 2015, 10:44 PM

Changes (6)

PathSize
src/
lint/
linter/
xhpast/
rules/
__tests__/
ArcanistIsAShouldBeInstanceOfXHPASTLinterRuleTestCase.php
ArcanistObjectOperatorSpacingXHPASTLinterRuleTestCase.php

rARCb3e68c9f1793

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistIsAShouldBeInstanceOfXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistIsAShouldBeInstanceOfXHPASTLinterRuleTestCase.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/is_a-should-be-instanceof/allow_string.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/is_a-should-be-instanceof/is_a.lint-test

Loading...