Home GnuPG

Improve strictness around `setLine()` types in ArcanistLintMessage
bd1da9da6c67Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Improve strictness around setLine() types in ArcanistLintMessage

Summary: Fixes T8921. Harbormaster is strict about types it accepts, but ArcanistLintMessage is more liberal. Push the strictness barrier down to the linter level, while maintaining reasonable flexibility in the API.

Test Plan: arc unit --everything

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T8921

Differential Revision: https://secure.phabricator.com/D13695

Details

Provenance
epriestley <git@epriestley.com>Authored on Jul 23 2015, 10:19 PM
Parents
rARC5e4f9a2bf9d2: Fix checkstyle severities
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rARCbd1da9da6c67: Improve strictness around `setLine()` types in ArcanistLintMessage (authored by epriestley <git@epriestley.com>).Jul 23 2015, 10:19 PM