Improve undeclared variables linter rule
bf4e7d4ca89aUnpublished
Actions

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Improve undeclared variables linter rule

Summary: Currently ArcanistUndeclaredVariableXHPASTLinterRule does not properly handle anonymous closures.

Test Plan: Added test cases.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: johnny-bit, Korvin

Differential Revision: https://secure.phabricator.com/D13795

Details

Provenance

Joshua Spence <josh@joshuaspence.com>

Authored on Aug 5 2015, 10:57 PM

Parents

rARC402899a9c32d: Allow closing tags in files containing HTML

Branches

Unknown

Tags

Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rARCbf4e7d4ca89a: Improve undeclared variables linter rule (authored by Joshua Spence <josh@joshuaspence.com>).Aug 5 2015, 10:57 PM

Changes (2)

Path

Size

src/

lint/

linter/

__tests__/

xhpast/

undeclared-variables.lint-test

xhpast/

rules/

ArcanistUndeclaredVariableXHPASTLinterRule.php

rARCbf4e7d4ca89a

View Options

src/lint/linter/tests/xhpast/undeclared-variables.lint-test