Home GnuPG
Diffusion Arcanist bf88f4616cdf

Add a linter rule for global variables
bf88f4616cdfUnpublished
Actions

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Add a linter rule for global variables

Summary: Ref T7409. Global variables are gross and should be avoided like the plague.

Test Plan: Added test cases.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Maniphest Tasks: T7409

Differential Revision: https://secure.phabricator.com/D13882

Details

Provenance
Joshua Spence <josh@joshuaspence.com>Authored on Aug 13 2015, 11:37 PM
Parents
rARCf4c322cb72cd: Add a linter rule for list assignments
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rARCbf88f4616cdf: Add a linter rule for global variables (authored by Joshua Spence <josh@joshuaspence.com>).Aug 13 2015, 11:37 PM

Changes (5)

PathSize
src/
lint/
linter/
__tests__/
xhpast/
xhpast/
rules/

rARCbf88f4616cdf

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/global-variables.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/naming-conventions.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/undeclared-variables.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistGlobalVariableXHPASTLinterRule.php

Loading...