Home GnuPG

Remove obsolete "arc land" flags: --update-with-merge/rebase, --delete-remote
c04f141ab023Unpublished

Unpublished Commit ยท Learn More

Publishing Disabled: All publishing is disabled for this repository.

Description

Remove obsolete "arc land" flags: --update-with-merge/rebase, --delete-remote

Summary:
Fixes T12815. During the last update to "arc land", some flags were disabled but remained in place in case we needed to retain them.

It now seems reasonably clear that we do not. The "rebase" and "merge" strategies for landing were replaced by a better "headless" strategy which seems to avoid the original issues, so these flags no longer do anything or reasonably could do anything.

--delete-remote is slightly more ambiguous (e.g., see T12650 and maybe others) but the only real use case is "git push = save changes".

Test Plan:
Ran arc land --update-with-rebase, was told the flag does not exist.
Grepped for affected flags/symbols.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12815

Differential Revision: https://secure.phabricator.com/D18108

Details

Provenance
epriestley <git@epriestley.com>Authored on Jun 9 2017, 3:52 PM
marcusPushed on Jun 27 2017, 9:10 PM
Parents
rARC129d51fa0936: If the base commit for `arc patch` does not exist locally, try to fetch it
Branches
Unknown
Tags
Unknown
References
HEAD -> master

Event Timeline