Home GnuPG

Allow "arc upload" to work correctly if it can not hash content
c4e84550fcd3Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Allow "arc upload" to work correctly if it can not hash content

Summary:
Ref T12464. This is similar to D17619 and prepares us to move to SHA256 in the client.

Note that it's fine if arc and Phabricator disagree about hashing algorithms. We don't really trust the client anyway, so if things are mismatched clients will just end up transferring a bit more data instead of getting to cheat when Phabricator already has copies of data.

Test Plan: Ran arc upload, got a clean upload.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12464

Differential Revision: https://secure.phabricator.com/D17621

Details

Provenance
epriestley <git@epriestley.com>Authored on Apr 5 2017, 12:46 AM
Parents
rARC82b7cd778a28: Make "arc download" use "file.search" if available
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rARCc4e84550fcd3: Allow "arc upload" to work correctly if it can not hash content (authored by epriestley <git@epriestley.com>).Apr 5 2017, 1:24 AM