Home GnuPG

When `arc` pushes to the staging area, tell Phabricator what we did
ccbaee585e1aUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

When arc pushes to the staging area, tell Phabricator what we did

Summary:
Ref T10093. Right now, Phabricator kind of guesses that arc probably pushed stuff to the staging area.

This can cause confusing/misleading errors later, if it didn't actually push.

Instead, tell Phabricator that we pushed, so we can raise more tailored messages in the web UI (e.g., make "Land Revision" say "this wasn't pushed to the staging area" instead of "whoops, error!!~").

Test Plan:
Ran arc diff a few times, then looked in the database for properties.

{F1161655}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10093

Differential Revision: https://secure.phabricator.com/D15426

Details

Provenance
epriestley <git@epriestley.com>Authored on Mar 7 2016, 4:13 PM
Parents
rARC4a1160e0c3a2: When pushing changes to staging, also push the base commit
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rARCccbaee585e1a: When `arc` pushes to the staging area, tell Phabricator what we did (authored by epriestley <git@epriestley.com>).Mar 7 2016, 4:24 PM