Improve the declaration parentheses linting
Summary: Improve ArcanistClosingDeclarationParenthesesXHPASTLinterRule (and rename it to ArcanistDeclarationParenthesesXHPASTLinterRule) to ensure that there is no whitespace before the opening parenthesis of a function/method declaration.
Test Plan: Added test cases.
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: epriestley, Korvin
Differential Revision: https://secure.phabricator.com/D13675