Home GnuPG

Use --no-ext-diff in `arc land` call to `git diff`
e5be662d15a8Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Use --no-ext-diff in arc land call to git diff

Summary:
Fixes T11435. This isn't a perfect solution since there's a little code duplication, but a perfect solution is probably a bit more involved.

See T11435 for some discussion. In particular, most git diff commands already get this flag via ArcanistGitAPI->getDiffBaseOptions().

Test Plan: Will land this change.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11435

Differential Revision: https://secure.phabricator.com/D16375

Details

Provenance
epriestley <git@epriestley.com>Authored on Aug 6 2016, 3:37 PM
Parents
rARC3aa47195ef08: Set "history.immutable" to "false" explicitly in .arcconfig in Arcanist
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rARCe5be662d15a8: Use --no-ext-diff in `arc land` call to `git diff` (authored by epriestley <git@epriestley.com>).Aug 6 2016, 6:00 PM