Home GnuPG

Improve validation of 'name' and 'code' parameters for lint messages
e8a0ebaeffaaUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Improve validation of 'name' and 'code' parameters for lint messages

Summary: Ref T9145. Fixes T9316. We now require "name" and "code" has a maximum length (currently, this is 32, but the next diff will raise it to 128).

Test Plan:

  • Installed PHPCS.
  • Hit both the "name" and "code" issues.
  • Applied this patch.
  • Got better errors sooner.

Reviewers: chad

Reviewed By: chad

Subscribers: aik099

Maniphest Tasks: T9145, T9316

Differential Revision: https://secure.phabricator.com/D14165

Details

Provenance
epriestley <git@epriestley.com>Authored on Sep 25 2015, 8:16 PM
Parents
rARC9c056c5cc887: Improve arc's handling of dirty submodules in Git
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rARCe8a0ebaeffaa: Improve validation of 'name' and 'code' parameters for lint messages (authored by epriestley <git@epriestley.com>).Sep 25 2015, 8:16 PM