Improve PHP compatibility linter
f43b74c6052fUnpublished
Actions

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Improve PHP compatibility linter

Summary: Ref T8674. Adds to ArcanistPHPCompatibilityXHPASTLinterRule such that an error is raised whenever self or $this is used in an anonymous closure prior to PHP 5.4.

Test Plan: Added test cases.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Maniphest Tasks: T8674

Differential Revision: https://secure.phabricator.com/D13841

Details

Provenance

Joshua Spence <josh@joshuaspence.com>

Authored on Aug 10 2015, 10:48 PM

Parents

rARC9e65fc65164a: Improve declaration formatting linter rule for anonymous functions

Branches

Unknown

Tags

Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rARCf43b74c6052f: Improve PHP compatibility linter (authored by Joshua Spence <josh@joshuaspence.com>).Aug 10 2015, 10:48 PM

Changes (2)

Path

Size

src/

lint/

linter/

__tests__/

xhpast/

php54-features.lint-test

xhpast/

rules/

ArcanistPHPCompatibilityXHPASTLinterRule.php

rARCf43b74c6052f

View Options

src/lint/linter/tests/xhpast/php54-features.lint-test