g10: Fix exporting secret keys of certain sizes.
02cf1357dd5eUnpublished
Actions

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

g10: Fix exporting secret keys of certain sizes.

* g10/build-packet.c (do_key): Do not use the header length specified
by the public key packet from the keyring, but let 'write_header2'
compute the required length.

Specifically exporting RSA keys of length 1024 failed, as the encoded
public key packet requires 141 bytes a length that fits into one byte,
but the secret key is significantly larger, making the export fail.

GnuPG-bug-id: T2307
Signed-off-by: Justus Winter <justus@g10code.com>

Details

Provenance

justus

Authored on Apr 7 2016, 1:55 PM

Parents

rG71040f48ef6b: g10: Fix typo.

Branches

Unknown

Tags

Unknown

Event Timeline

Justus Winter <justus@g10code.com> committed rG02cf1357dd5e: g10: Fix exporting secret keys of certain sizes. (authored by Justus Winter <justus@g10code.com>).Apr 7 2016, 1:55 PM

justus mentioned this in Unknown Object (Maniphest Task).Mar 27 2017, 5:09 PM

justus mentioned this in Unknown Object (Maniphest Task).Mar 27 2017, 5:32 PM

justus mentioned this in T2307: Failure to export secret key (Can't encode length=518 in a 2 byte header!).Mar 30 2017, 7:17 PM

Changes (1)

Path

Size

g10/

build-packet.c

rG02cf1357dd5e

View Options

g10: Fix exporting secret keys of certain sizes.02cf1357dd5eUnpublishedActions