Diffusion GnuPG 1ae16838660a

agent: Do not place a trailing NUL byte on S-expression

Authored by dkg on Jul 23 2019, 4:07 PM.

Description

agent: Do not place a trailing NUL byte on S-expression

agent/pkdecrypt.c (agent_pkdecrypt): Avoid appending a trailing NUL
byte at the end of the generated S-expression.

In many cases, a canonical S-expression may have an embedded NUL
anyway (especially if it contains raw cryptographic key material or
other high-entropy bytestrings), so trying to treat a canonical
S-expression as a C string is likely to be dangerous -- better to not
leave any such expectations.

  • GnuPG-bug-id: T4652
  • Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>

Details

Committed
dkgJul 23 2019, 5:47 PM
Parents
rG7bfbb9fa7e76: gpg: A little clean up.
Branches
Unknown
Tags
Unknown
This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.