Home GnuPG
Diffusion Phabricator 00313094d3ab

Make "View" links on Differential inline comment previews work again
00313094d3abUnpublished
Actions

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Make "View" links on Differential inline comment previews work again

Summary:
Ref T11114. Recent changes broke the links to jump to inline comments from the previews because they get hooked up with JS.

Restore the linking behavior.

Test Plan: Clicked "View" on an inline comment preview, jumped to that comment.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114

Differential Revision: https://secure.phabricator.com/D17131

Details

Provenance
epriestley <git@epriestley.com>Authored on Jan 2 2017, 7:48 PM
Parents
rPHAB34d279abde77: Add responsive spacing to comment form info view
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHAB00313094d3ab: Make "View" links on Differential inline comment previews work again (authored by epriestley <git@epriestley.com>).Jan 2 2017, 10:24 PM

Changes (4)

PathSize
src/
infrastructure/
diff/
view/
webroot/
rsrc/
js/
application/
transactions/

rPHAB00313094d3ab

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentPreviewListView.php

Loading...
View Options

webroot/rsrc/js/application/diff/behavior-preview-link.js

Loading...
View Options

webroot/rsrc/js/application/transactions/behavior-comment-actions.js

Loading...