Home GnuPG

Add `bin/auth unlimit` and clean up a TODO
0449a07f537dUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Add bin/auth unlimit and clean up a TODO

Summary:
I stumbled across this TODO and was worried that there was a glaring hole in MFA that I'd somehow forgotten about, but the TODO is just out of date.

These actions are rate limited properly by PhabricatorAuthTryFactorAction, which permits a maximum of 10 actions per hour.

  • Remove the TODO.
  • Add bin/auth unlimit to make it easier to reset rate limits if someone needs to do that for whatever reason.

Test Plan:

  • Tried to brute force through MFA.
  • Got rate limited properly after 10 failures.
  • Reset rate limit with bin/auth unlimit.
  • Saw the expected number of actions clear.

{F805288}

Reviewers: chad

Reviewed By: chad

Subscribers: joshuaspence

Differential Revision: https://secure.phabricator.com/D14105

Details

Provenance
epriestley <git@epriestley.com>Authored on Sep 14 2015, 4:03 PM
Parents
rPHAB6bd8ee861ca7: Use PEAR Text_Figlet to render figlet fonts
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHAB0449a07f537d: Add `bin/auth unlimit` and clean up a TODO (authored by epriestley <git@epriestley.com>).Sep 14 2015, 4:03 PM