Home GnuPG

Immediately deactivate remarkup autocomplete if there's no query
130ebd2c421aUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Immediately deactivate remarkup autocomplete if there's no query

Summary:
Fixes T12479. If you end a line with a character like ":" in a context which can trigger autocomplete (e.g., .:), then try to make a newline, we swallow the keystroke.

Instead, allow the keystroke through if the user hasn't typed anything else yet.

Test Plan:

  • Autocompleted emoji and users normally.
  • In an empty textarea, typed .:<return>, got a newline instead of a swallowed keystroke.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12479

Differential Revision: https://secure.phabricator.com/D17583

Details

Provenance
epriestley <git@epriestley.com>Authored on Mar 30 2017, 5:32 PM
Parents
rPHABcb1d90465447: Make sure writes go to the right cluster
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHAB130ebd2c421a: Immediately deactivate remarkup autocomplete if there's no query (authored by epriestley <git@epriestley.com>).Mar 30 2017, 8:29 PM