Home GnuPG

Don't show the "Override Lock" prompt when creating objects
1953ab98be2bUnpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Don't show the "Override Lock" prompt when creating objects

Summary:
Fixes T12369. When you create objects they may technically be locked: either because the default state is legitimately locked, or because the default policies prevent you from viewing so we sort of technically end in a locked state.

Regardless, don't prompt during creation, since this prompt isn't useful even if the lock detection is completely legitimate.

Test Plan:

  • In ApplicationsManiphestConfigure, set "Default View Policy" to "No One".
  • Tried to create a task.
  • Before patch: prompted to override lock.
  • After patch: no override prompt.

Reviewers: chad

Reviewed By: chad

Subscribers: d.maznekov

Maniphest Tasks: T12369

Differential Revision: https://secure.phabricator.com/D17541

Details

Provenance
epriestley <git@epriestley.com>Authored on Mar 23 2017, 1:41 PM
Parents
rPHABaa91dc992e24: Record which user accepted on behalf of packages/owners reviewers
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHAB1953ab98be2b: Don't show the "Override Lock" prompt when creating objects (authored by epriestley <git@epriestley.com>).Mar 23 2017, 2:40 PM