Home GnuPG
Diffusion Phabricator 1c088822b4d2

Fix a fatal when viewing a daemon task with an invalid ID
1c088822b4d2Unpublished
Actions

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Fix a fatal when viewing a daemon task with an invalid ID

Summary:
Fixes T11295. Prior to this change, the "404 page" for daemon tasks fatals.

This page is special cased a little bit and not a normal 404 page, because it's possible for you to click a valid link and the task to get GC'd by the time you load the page, or similar. It tries to be a little more user-friendly than a bare 404.

Test Plan:

  • Visited /daemon/task/1428348920328/ (any invalid ID).
  • Now got a nice "no such task" page.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11295

Differential Revision: https://secure.phabricator.com/D16254

Details

Provenance
epriestley <git@epriestley.com>Authored on Jul 8 2016, 1:31 PM
Parents
rPHABc5efb453befd: Show more repository information in Owners path editing dropdown
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHAB1c088822b4d2: Fix a fatal when viewing a daemon task with an invalid ID (authored by epriestley <git@epriestley.com>).Jul 8 2016, 4:08 PM

Changes (1)

PathSize
src/
applications/
daemon/
controller/

rPHAB1c088822b4d2

View Options

src/applications/daemon/controller/PhabricatorWorkerTaskDetailController.php

Loading...